Add AST getAll[Supported]Versions and isSupportedVersion #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eclipse-jdt/eclipse.jdt.ui#1948 is an example of usage of new API. |
|
@iloveeclipse IIRC you added the similar API in JavaCore so would you please take a look. |
| @@ -1193,7 +1204,7 @@ private AST(int level, boolean previewEnabled) { | |||
| false/*isPreviewEnabled*/); | |||
| break; | |||
| default: | |||
| if (level < JLS2_INTERNAL && level > JLS_Latest) { | |||
| if (!ALL_VERSIONS.contains(level)) { | |||
There was a problem hiding this comment.
Should it be SUPPORTED_VERSIONS ?
There was a problem hiding this comment.
Using SUPPORTED_VERSIONS should happen in #3533 together with switching the mapping to prevent inconsistencies.
iloveeclipse
approved these changes
Jan 17, 2025
|
I'll wait Monday and push it if no one jumps in. |
New methods to ease finding all/supported JLS versions. Supported JLS versions helpers are needed in order ease limiting AST support to what compiler supports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New methods to ease finding all/supported JLS versions. Supported JLS versions helpers are needed in order ease limiting AST support to what compiler supports.